(WIP) TS: fast forward and propagation policy change#10576
Open
feiyang3cat wants to merge 11 commits into
Open
(WIP) TS: fast forward and propagation policy change#10576feiyang3cat wants to merge 11 commits into
feiyang3cat wants to merge 11 commits into
Conversation
feiyang3cat
force-pushed
the
ts-fast-forward
branch
6 times, most recently
from
d5aa678 to
ad54d2d
Compare
feiyang3cat
force-pushed
the
ts-fast-forward
branch
2 times, most recently
from
861e03b to
b46afaa
Compare
prathyushpv
reviewed
Jun 10, 2026
prathyushpv
reviewed
Jun 10, 2026
feiyang3cat
force-pushed
the
ts-fast-forward
branch
3 times, most recently
from
9ae6e10 to
5d05103
Compare
feiyang3cat
changed the title
feiyang3cat
force-pushed
the
ts-fast-forward
branch
5 times, most recently
from
1000c5e to
1753d5b
Compare
simvlad
reviewed
Jun 11, 2026
| disableChildPropagation := source.GetTimeSkippingInfo().GetConfig().GetDisableChildPropagation() | ||
| enabled := source.GetTimeSkippingInfo().GetConfig().GetEnabled() | ||
| if !enabled || disableChildPropagation { | ||
| return nil, nil |
Contributor
There was a problem hiding this comment.
So we do not propagate the virtual time to the child in this case? This contradicts the described behavior in API PR:
// but a parent's fast_forward won't affect its child's execution. A flag is provided to disable propagation of the
// "enabled" flag to child workflows; regardless of that flag, a child workflow inherits the virtual time from the
// parent execution as its start time.```
| func (ms *MutableStateImpl) applyTimeSkippingBound(currentEventID int64) { | ||
| // applyFastForward (re)computes the FastForwardInfo using the new TimeSkippingConfig and propagated time-skippingstates. | ||
| // This method should be called whenever the TimeSkippingConfig is initialized or updated. | ||
| func (ms *MutableStateImpl) applyFastForward(currentEventID int64, propagatedTargetTime *timestamppb.Timestamp) { |
Contributor
There was a problem hiding this comment.
Does this get executed even when unrelated field is updated? So say you have a 2h fast-forward set and you are 1 hour into it. If you update some other workflow option, it looks like you would just recalculate fast-forward to now + 2h.
| return tsc, stateProp | ||
| } | ||
|
|
||
| // propagateTimeSkippingToChild makes sure the start time of the child workflow execution |
Contributor
There was a problem hiding this comment.
No changes needed, but just a comment for my understanding. Is my assumption about the behavior is correct: you fast forward 5 minutes, and all child workflows created during that time will skip the time unbounded.
Contributor
Author
There was a problem hiding this comment.
yes, but we recommend using fast forward with disable-propagation-for-child if child workflows also need to stop in the middle of somewhere and send signals
feiyang3cat
force-pushed
the
ts-fast-forward
branch
6 times, most recently
from
33747da to
55b6e00
Compare
feiyang3cat
force-pushed
the
ts-fast-forward
branch
from
55b6e00 to
31fd287
Compare
feiyang3cat
changed the title
feiyang3cat
force-pushed
the
ts-fast-forward
branch
4 times, most recently
from
f349bb3 to
fe2c66e
Compare
feiyang3cat
force-pushed
the
ts-fast-forward
branch
from
0237a9e to
29fd7f1
Compare
feiyang3cat
force-pushed
the
ts-fast-forward
branch
from
29fd7f1 to
8e62251
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
make server compatible to breaking api change
time skipping fast forward api#786
change the propagation policy of time skipping to
virtual time is always propagated to have causal time
but the fast forward action is never propagated
configuration propagation is controlled by a separate flag
How did you test it?
Potential risks
the sequence of this pr